Make the Pen tool close a path by double-clicking #3311
Conversation
Signed-off-by: krVatsal <[email protected]>
|
!build |
|
|
Do i need to do something in order to get this pr reviewed? |
|
No, everything fine we're just a bit behind on PRs, situation will improve when Keavon is back from vacation. Thanks for contributing :) |
|
Sure, thanks! |
|
!build |
|
Fails to compile now. |
timon-schelling
force-pushed
the
master
branch
from
124235a to
a42cad8
Compare
The conflicts are resolved , can you review this one also. |
|
!build |
Signed-off-by: krVatsal <[email protected]>
|
!build |
|
2026-01-13.18-10-26.mp4Doesn't seem to work as expected. |
|
Can you clarify what is the desired output, drawing should end without closing the path or it should close the the shape on double click? |
|
Closing the path, see the issue you linked. |
Signed-off-by: krVatsal <[email protected]>
…ool' of https://github.com/krVatsal/Graphite into add-feature-to-stop-drawing-on-double-click-using-pen-tool
krVatsal
changed the title
Can you review it now? |
|
!build |
|
timon-schelling
changed the title
|
LGTM, @0HyperCube any comments? |
0HyperCube
left a comment
0HyperCube
left a comment
There was a problem hiding this comment.
Seems good.
I guess you could have bound an event for DoubleClick in the input_mappings.rs but that would confuse the logic since it happens only on mouse up.
Keavon
changed the title
|
Yeah, from a behavioral perspective, this needs to not close the path upon releasing the mouse from a fast click-click-drag (double-clicking the mouse down part, but dragging during the second mouse down). Currently, that scenario results in unexpected behavior after mouse up. |
4 participants
Closes the active pen path when the user intentionally double-clicks.
Closes #3219